slfan1989 commented on code in PR #15897:
URL: https://github.com/apache/iceberg/pull/15897#discussion_r3292049634


##########
kafka-connect/kafka-connect-runtime/runtime-deps.txt:
##########
@@ -182,10 +180,24 @@ org.apache.parquet:parquet-variant:1.17
 org.bouncycastle:bcprov-jdk18on:1.84
 org.checkerframework:checker-compat-qual:2.5
 org.checkerframework:checker-qual:3.49
-org.codehaus.jettison:jettison:1.5
 org.codehaus.mojo:animal-sniffer-annotations:1.27
 org.codehaus.woodstox:stax2-api:4.2
 org.conscrypt:conscrypt-openjdk-uber:2.5
+org.glassfish.hk2.external:aopalliance-repackaged:2.6

Review Comment:
   Added the Glassfish excludes on the Kafka Connect runtime `hadoop3.common` 
dependency and also mirrored them on `:iceberg-open-api` test fixtures. I also 
excluded `org.javassist:javassist`. Regenerated `runtime-deps.txt` and verified 
the runtime baseline again.



##########
kafka-connect/build.gradle:
##########


Review Comment:
   Added the Glassfish excludes on the Kafka Connect runtime hadoop3.common 
dependency and also mirrored them on :iceberg-open-api test fixtures. I also 
excluded org.javassist:javassist. Regenerated runtime-deps.txt and verified the 
runtime baseline again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to