dramaticlly commented on code in PR #16449:
URL: https://github.com/apache/iceberg/pull/16449#discussion_r3291591135
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -232,36 +203,9 @@ private boolean credentialProvided() {
@Value.Check
protected void check() {
Preconditions.checkArgument(
- properties().containsKey(S3_SIGNER_URI)
- || properties().containsKey(RESTCatalogProperties.SIGNER_URI)
+ properties().containsKey(RESTCatalogProperties.SIGNER_URI)
|| properties().containsKey(CatalogProperties.URI),
"S3 signer service URI is required");
-
- if (properties().containsKey(S3_SIGNER_URI)
- && !properties().containsKey(RESTCatalogProperties.SIGNER_URI)) {
- LOG.warn(
- "S3 signer URI is configured via deprecated property {}, this won't
be supported in future releases. "
- + "Please use {} instead.",
- S3_SIGNER_URI,
- RESTCatalogProperties.SIGNER_URI);
- }
-
- if (properties().containsKey(S3_SIGNER_ENDPOINT)
- && !properties().containsKey(RESTCatalogProperties.SIGNER_ENDPOINT)) {
- LOG.warn(
- "Signer endpoint is configured via deprecated property {}, this
won't be supported in future releases. "
- + "Please use {} instead.",
- S3_SIGNER_ENDPOINT,
- RESTCatalogProperties.SIGNER_ENDPOINT);
- }
-
- // TODO change to required in 1.12.0
- if (!properties().containsKey(S3_SIGNER_ENDPOINT)
- && !properties().containsKey(RESTCatalogProperties.SIGNER_ENDPOINT)) {
- LOG.warn(
Review Comment:
yeah I think `RESTCatalogProperties.SIGNER_ENDPOINT` is replaced with
`RESTCatalogProperties.SIGNER_URI` and we can rely on LINE 206 to ensure its
existence. Sorry it's a bit messy right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
