fallintoplace commented on PR #1112: URL: https://github.com/apache/iceberg-go/pull/1112#issuecomment-4522036835
Thanks for the review. I pushed `a138222` addressing these: - moved the floored integer division helper into `internal.FloorDiv` and reused it from both timestamp transforms and partition timestamp unit conversion - added overflow coverage for timestamp unit scaling through partition extraction - added UTC timestamp/timestamp_ns cases to cover the `TimestampTz` and `TimestampTzNs` branches - changed `partitionFieldInfo` to keep `PartitionField` by value - switched the struct literal to named fields - made the missing-source-type error message distinct from the missing-source-field error Retested: - `go test ./table -run TestFanoutWriter -count=1` - `go test .` - `go test ./...` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
