pvary commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3287956907
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicCommitter.java:
##########
@@ -512,8 +607,7 @@ void testTableBranchAtomicCommitForAppendOnlyData() throws
Exception {
// Two committables, one for each snapshot / table / branch.
assertThat(table.snapshots()).hasSize(2);
- Snapshot snapshot1 = Iterables.getFirst(table.snapshots(), null);
-
assertThat(snapshot1.snapshotId()).isEqualTo(table.refs().get("branch1").snapshotId());
Review Comment:
commitRequest1 and commitRequest2 creates `branch1`, and they are both for
checkpointId1, only commitRequest3 should create `branch2` which is
checkpointId2.
How could it happen that `branch2` is the first snapshot?
Can we check the history, that the commits are in order as we expect them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
