HuaHuaY commented on PR #670:
URL: https://github.com/apache/iceberg-cpp/pull/670#issuecomment-4515576639

   I think a simpler fix would be to temporarily introduce a higher version of 
`fmt` in CI environment or CMake. Latest `fmt` has fixed this issue but `avro` 
will fetch an outdated `fmt` if it doesn't find a `fmt` package. There is a PR 
in `avro` which tries to replace `fmt` with `std::format`. We can remove the 
`fmt` after `avro` accepts the PR.
   ```cmake
   find_package(fmt QUIET)
   if (NOT fmt_FOUND)
       include(FetchContent)
       FetchContent_Declare(
               fmt
               GIT_REPOSITORY  https://github.com/fmtlib/fmt.git
               GIT_TAG         10.2.1
               GIT_PROGRESS    TRUE
               USES_TERMINAL_DOWNLOAD TRUE
       )
       FetchContent_MakeAvailable(fmt)
   endif ()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to