anoopj commented on code in PR #16506:
URL: https://github.com/apache/iceberg/pull/16506#discussion_r3284620824
##########
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##########
@@ -86,6 +87,7 @@ public void testAddManyFiles() {
}
@TestTemplate
+ @SetEnvironmentVariable(key = "ICEBERG_WORKER_NUM_THREADS", value = "3")
Review Comment:
Does this fix really work on machines with less than 3 cores? (which this
fix is targeting?) I think the static config `WORKER_THREAD_POOL_SIZE` might be
already initialized in the JVM by the time this test runs. (unless you got
really lucky with test timing).
##########
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##########
Review Comment:
Instead of the above fix, just drop this `multiplier` to 2? Probably gets
the same verification you are trying to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
