mithilgirish commented on PR #1104: URL: https://github.com/apache/iceberg-go/pull/1104#issuecomment-4513072076
Thanks for the detailed review! I've pushed a new commit addressing all points: * `gc.enabled` gate added — skips data-file deletion when false * URI dedup fixed using existing `normalizeFilePath` helper * Godoc aligned with Java/PyIceberg best-effort model * Hadoop now runs full union-walk before `os.RemoveAll` * Compile-time `var _ catalog.PurgeableTable` guards added to all catalogs * SQL test snapshot ID reads from `tbl.CurrentSnapshot().SnapshotID` * `TestRunDropTablePurgeError` added * CLI unified to `osExit(1)` * Stray regex removed Also added `ctx.Err()` checks in traversal loops and safe `os.ErrNotExist` handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
