Fokko commented on code in PR #16446:
URL: https://github.com/apache/iceberg/pull/16446#discussion_r3283810222
##########
format/spec.md:
##########
@@ -514,12 +514,16 @@ Partition field IDs must be reused if an existing
partition spec contains an equ
| **`truncate[W]`** | Value truncated to width `W` (see below)
| `int`, `long`, `decimal`, `string`, `binary`
| Source type |
| **`year`** | Extract a date or timestamp year, as years from 1970
| `date`, `timestamp`, `timestamptz`, `timestamp_ns`, `timestamptz_ns`
| `int` |
| **`month`** | Extract a date or timestamp month, as months from
1970-01-01 | `date`, `timestamp`, `timestamptz`, `timestamp_ns`,
`timestamptz_ns` | `int` |
-| **`day`** | Extract a date or timestamp day, as days from 1970-01-01
| `date`, `timestamp`, `timestamptz`, `timestamp_ns`, `timestamptz_ns`
| `int` |
+| **`day`** | Extract a date or timestamp day, as days from 1970-01-01
| `date`, `timestamp`, `timestamptz`, `timestamp_ns`, `timestamptz_ns`
| `int` [1] |
Review Comment:
```suggestion
| **`day`** | Extract a date or timestamp day, as days from
1970-01-01 | `date`, `timestamp`, `timestamptz`, `timestamp_ns`,
`timestamptz_ns` | `date` |
```
I think having the `int` conflicts with the Avro types table below:
https://github.com/apache/iceberg/blob/main/format/spec.md#avro
If we decide to keep the partition Tuple in V4, then we would also add the
`date` logical type annotation in Parquet:
https://github.com/apache/iceberg/blob/main/format/spec.md#parquet I think this
would be the most consistent.
This would effectively revert it back to `date` which it was before:
https://github.com/apache/iceberg/issues/10616#issuecomment-2200191427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
