nastra commented on code in PR #16452:
URL: https://github.com/apache/iceberg/pull/16452#discussion_r3280851051
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -757,44 +753,13 @@ private static CloseableIterable<Record>
positionDeletesReader(
}
private static PositionDeleteWriter<Record> positionDeletesWriter(
- OutputFile outputFile,
- FileFormat format,
- PartitionSpec spec,
- StructLike partition,
- Schema rowSchema)
+ OutputFile outputFile, FileFormat format, PartitionSpec spec, StructLike
partition)
throws IOException {
- if (rowSchema == null) {
- return FormatModelRegistry.<Record>positionDeleteWriteBuilder(
- format, EncryptedFiles.plainAsEncryptedOutput(outputFile))
- .partition(partition)
- .spec(spec)
- .build();
- } else {
- return switch (format) {
Review Comment:
can you please elaborate why these changes are being done here? This doesn't
seem to be related to removing deprecated APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
