mxm commented on code in PR #16329:
URL: https://github.com/apache/iceberg/pull/16329#discussion_r3279478457
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/DeleteOrphanFiles.java:
##########
@@ -209,72 +209,73 @@ DataStream<TaskResult> append(DataStream<Trigger>
trigger) {
// Collect all data files
SingleOutputStreamOperator<MetadataTablePlanner.SplitInfo> splits =
- trigger
- .process(
- new MetadataTablePlanner(
- taskName(),
- index(),
- tableLoader(),
- FILE_PATH_SCAN_CONTEXT,
- MetadataTableType.ALL_FILES,
- planningWorkerPoolSize))
- .name(operatorName(PLANNER_TASK_NAME))
- .uid(PLANNER_TASK_NAME + uidSuffix())
- .slotSharingGroup(slotSharingGroup())
- .forceNonParallel();
+ setSlotSharingGroup(
+ trigger
+ .process(
+ new MetadataTablePlanner(
+ taskName(),
+ index(),
+ tableLoader(),
+ FILE_PATH_SCAN_CONTEXT,
+ MetadataTableType.ALL_FILES,
+ planningWorkerPoolSize))
+ .name(operatorName(PLANNER_TASK_NAME))
+ .uid(PLANNER_TASK_NAME + uidSuffix())
+ .forceNonParallel());
Review Comment:
That's a very invasive change touching all operators. Is there no other way
to set the SlotSharingGroup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
