nastra commented on code in PR #16441:
URL: https://github.com/apache/iceberg/pull/16441#discussion_r3279477504
##########
core/src/test/java/org/apache/iceberg/TestStatsUtil.java:
##########
@@ -87,62 +91,63 @@ public void statsIdsForTableColumns() {
@Test
public void statsIdsOverflowForTableColumns() {
- // pick 100 random IDs that are > MAX_FIELD_ID and <
METADATA_SPACE_FIELD_ID_START as going over
+ // pick 100 random IDs that are > MAX_FIELD_ID and <
RESERVED_FIELD_IDS_START as going over
// the entire ID range takes too long
int invalidFieldId = -1;
for (int i = 0; i < 100; i++) {
int id =
ThreadLocalRandom.current()
- .nextInt(
- StatsUtil.MAX_DATA_FIELD_ID + 1,
- StatsUtil.STATS_SPACE_FIELD_ID_START_FOR_METADATA_FIELDS);
+ .nextInt(StatsUtil.MAX_DATA_FIELD_ID + 1,
RESERVED_FIELD_IDS_START);
assertThat(StatsUtil.statsFieldIdForField(id)).as("at pos %s",
id).isEqualTo(invalidFieldId);
}
assertThat(StatsUtil.fieldIdForStatsField(-1)).isEqualTo(invalidFieldId);
+ assertThat(StatsUtil.fieldIdForStatsField(0)).isEqualTo(invalidFieldId);
+ assertThat(StatsUtil.fieldIdForStatsField(200)).isEqualTo(invalidFieldId);
assertThat(StatsUtil.fieldIdForStatsField(5_000)).isEqualTo(invalidFieldId);
+
assertThat(StatsUtil.fieldIdForStatsField(8_600)).isEqualTo(invalidFieldId);
assertThat(StatsUtil.fieldIdForStatsField(10_001)).isEqualTo(invalidFieldId);
assertThat(StatsUtil.fieldIdForStatsField(10_201)).isEqualTo(invalidFieldId);
assertThat(StatsUtil.fieldIdForStatsField(10_500)).isEqualTo(invalidFieldId);
assertThat(StatsUtil.fieldIdForStatsField(10_900)).isEqualTo(invalidFieldId);
+
+ // stats field IDs at or above the exclusive upper bound are invalid
+
assertThat(StatsUtil.fieldIdForStatsField(StatsUtil.STATS_SPACE_FIELD_ID_END))
+ .isEqualTo(invalidFieldId);
+
assertThat(StatsUtil.fieldIdForStatsField(StatsUtil.STATS_SPACE_FIELD_ID_END +
200))
+ .isEqualTo(invalidFieldId);
+
assertThat(StatsUtil.fieldIdForStatsField(Integer.MAX_VALUE)).isEqualTo(invalidFieldId);
+
+ // field ID just past MAX_DATA_FIELD_ID is invalid
+ assertThat(StatsUtil.statsFieldIdForField(StatsUtil.MAX_DATA_FIELD_ID + 1))
+ .isEqualTo(invalidFieldId);
}
@Test
public void statsIdsForReservedColumns() {
Review Comment:
updated but I think we use reserved vs metadata column interchangibly
because reserved usually refers to "reserved field ids" as defined in the spec.
In other places we just refer to this via "metadata columns"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
