pvary commented on code in PR #15596:
URL: https://github.com/apache/iceberg/pull/15596#discussion_r3278889634
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFormatModel.java:
##########
@@ -267,6 +289,9 @@ public FileAppender<D> build() throws IOException {
* top-level fields.
*/
private FileAppender<D> buildShreddedAppender() {
+ UnaryOperator<D> copyFunc = copyFuncFactory.apply(engineSchema);
+ Preconditions.checkState(copyFunc != null, "copyFunc must not return
null");
Review Comment:
Checking only the copyFunc seems a bit odd to me. Should we check the
factory first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
