pvary commented on code in PR #16423:
URL: https://github.com/apache/iceberg/pull/16423#discussion_r3273515450
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java:
##########
@@ -243,6 +243,29 @@ public void testCreateTableLikeInFlinkCatalog() throws
TableNotExistException {
.containsEntry(FlinkCreateTableOptions.SRC_CATALOG_PROPS_KEY,
srcCatalogProps);
}
+ @TestTemplate
+ public void testCreateTableWithTableComment() {
+ // create table with comment
+ sql("CREATE TABLE tl(id BIGINT) COMMENT 'table comment'");
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put("comment", "table comment");
+ assertThat(table("tl").properties()).containsAllEntriesOf(properties);
+ }
+
+ @TestTemplate
+ public void testAlterTableModifyTableComment() {
+ // create table with comment
+ sql("CREATE TABLE tl(id BIGINT) COMMENT 'table comment'");
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put("comment", "table comment");
+ assertThat(table("tl").properties()).containsAllEntriesOf(properties);
Review Comment:
```suggestion
assertThat(table("tl").properties()).containsEntry(TableProperties.COMMENT,
"table comment");
```
And then we don't need the extra `Map`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
