qzyu999 commented on PR #3361: URL: https://github.com/apache/iceberg-python/pull/3361#issuecomment-4494900244
Hi @rambleraptor, thanks for the PR, quick comment, it may make sense to link that this Closes #1200. I do see a related PR #1958, but it looks potentially abandoned (CC: @jayceslesar). _NOTE:_ I notice that you call it remove orphan files, while the linked issue is called delete orphan files. The Java code itself calls it `DeleteOrphanFiles`, however the API for Spark and Trino use `remove_orphan_files`. Did a bit of research to try and understand why. Seems to potentially avoid ambiguity regarding doing row-level deleting, making it more user-friendly where "remove" is known to be a house-keeping type operation. The Java naming of choosing "delete" actually matches their CRU**D** interface since they are performing a delete operation on files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
