smaheshwar-pltr commented on code in PR #3220:
URL: https://github.com/apache/iceberg-python/pull/3220#discussion_r3270015468
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -953,6 +958,29 @@ def create_table_transaction(
staged_table =
self._response_to_staged_table(self.identifier_to_tuple(identifier),
table_response)
return CreateTableTransaction(staged_table)
+ @override
+ @retry(**_RETRY_ARGS)
+ def replace_table_transaction(
Review Comment:
Java's
[`RESTSessionCatalog.replaceTransaction`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L1035-L1037)
does a view-existence check before replacing (see
[apache/iceberg#9012](https://github.com/apache/iceberg/pull/9012)).
Leaving that implementation + tests for a follow-up PR (if folks are fine
with that), I'm wary this PR is large as is and feel that this is fine to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
