fallintoplace opened a new pull request, #661: URL: https://github.com/apache/iceberg-cpp/pull/661
## Summary - keep `UseRef()` snapshot IDs as `int64_t` while resolving refs - add a regression test for a ref pointing at `INT32_MAX + 42` ## Root Cause `TableScanBuilder::UseRef()` copied `SnapshotRef::snapshot_id` into an `int32_t`, even though snapshot IDs are modeled as `int64_t` in refs, metadata lookup, and scan context. ## Testing - `uvx cmake --build build --target scan_test -j 8` - `./build/src/iceberg/test/scan_test --gtest_filter=*UseRefPreservesInt64SnapshotIds*` - `./build/src/iceberg/test/scan_test` Fixes #660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
