amogh-jahagirdar commented on code in PR #16158:
URL: https://github.com/apache/iceberg/pull/16158#discussion_r3267559847
##########
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##########
@@ -52,19 +55,19 @@ public class BaseDVFileWriter implements DVFileWriter {
private static final String REFERENCED_DATA_FILE_KEY =
"referenced-data-file";
private static final String CARDINALITY_KEY = "cardinality";
- private final Supplier<OutputFile> dvOutputFile;
+ private final Supplier<EncryptedOutputFile> dvOutputFile;
private final Function<String, PositionDeleteIndex> loadPreviousDeletes;
private final Map<String, Deletes> deletesByPath = Maps.newHashMap();
private final Map<String, BlobMetadata> blobsByPath = Maps.newHashMap();
private DeleteWriteResult result = null;
public BaseDVFileWriter(
OutputFileFactory fileFactory, Function<String, PositionDeleteIndex>
loadPreviousDeletes) {
- this(() -> fileFactory.newOutputFile().encryptingOutputFile(),
loadPreviousDeletes);
+ this(fileFactory::newOutputFile, loadPreviousDeletes);
}
public BaseDVFileWriter(
- Supplier<OutputFile> dvOutputFile,
+ Supplier<EncryptedOutputFile> dvOutputFile,
Review Comment:
I'm a bit surprised revAPI didn't catch this since it's a breaking change
unfortunately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
