jdwil commented on issue #2028:
URL: https://github.com/apache/iceberg-rust/issues/2028#issuecomment-4487553557
I've opened a PR for this:
https://github.com/apache/iceberg-rust/pull/2469
(https://github.com/apache/iceberg-rust/pull/2469)
This takes a different approach from the earlier #2037 (which was closed
as stale). Rather than adding a separate additional_properties field,
TableProperties now owns the raw HashMap<String, String> internally and
provides both typed
access to known properties and delegate methods (get, contains_key, iter,
as_raw) for arbitrary/unknown keys. This addresses the original review feedback
about removing the properties() -> &HashMap accessor and using TryFrom instead
of
unwrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
