stevenzwu commented on code in PR #15630: URL: https://github.com/apache/iceberg/pull/15630#discussion_r3262540892
########## format/spec.md: ########## @@ -1647,6 +1732,30 @@ The binary single-value serialization can be used to store the lower and upper b ## Appendix E: Format version changes +### Version 4 + +Relative path support is added in v4. + +Reading v3 metadata for v4: + +* All location fields are fully-qualified paths and interpreted as absolute paths for v4 +* Any location field without a uri scheme prefix must prepend a scheme component consistent with v4 absolute paths + +Writing v4 metadata: + +* Table metadata JSON: + * `location` is now optional and must be absolute when present + * When not present, the table location must be managed externally and provided when loading the metadata +* Location fields in all metadata structures may contain relative paths +* Writers should produce relative paths by default for files that reside under the table location +* Absolute paths must be used for files that do not share a common prefix with the table location Review Comment: > Absolute paths must be used for all other files. line 1751 can be simplified as `for all other files`. We don't even need to mention `that don't share a common prefix ...`, which can leads to misinterpretation. But I will leave it up to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
