happydave1 commented on PR #1045: URL: https://github.com/apache/iceberg-go/pull/1045#issuecomment-4482095788
@laskoviymishka Thanks for the previous review - the issues spotted were definitely good catches. Also thanks for the clear and precise communication - it made fixing the issues a lot easier. Another restructure since last time. I found that once I fixed the bug caused by using `FindFieldByName()`, the partial cases were failing since all row lineage metadata was being stripped from `selectedFields`, thus leading to lost data - Good catch! So this round I focused on making sure only metadata which needed to be synthesized is properly synthesized. Now the synthesis path (`scanner.go:271`) is only gated by the version and whether or not any metadata has to be synthesized. I think that this approach is much cleaner and clearer. I also fixed the carry-over issue of `sch.IndentifierFieldIDs` being dropped by using `iceberg.NewSchemaWithIdentifiers`. Please let me know what you think, any feedback would be greatly appreciated. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
