smaheshwar-pltr commented on code in PR #3220:
URL: https://github.com/apache/iceberg-python/pull/3220#discussion_r3261049245
##########
pyiceberg/catalog/__init__.py:
##########
@@ -323,6 +328,20 @@ def delete_data_files(io: FileIO, manifests_to_delete:
list[ManifestFile]) -> No
deleted_files[path] = True
+def _raise_if_view_exists(catalog: Catalog, identifier: str | Identifier) ->
None:
Review Comment:
Mirrors Java's [view-collision pre-flight in
`RESTSessionCatalog.replaceTransaction`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L1035-L1037).
`NotImplementedError` from `view_exists` is treated as "no view" for catalogs
that don't model them.
##########
pyiceberg/catalog/__init__.py:
##########
@@ -323,6 +328,20 @@ def delete_data_files(io: FileIO, manifests_to_delete:
list[ManifestFile]) -> No
deleted_files[path] = True
+def _raise_if_view_exists(catalog: Catalog, identifier: str | Identifier) ->
None:
Review Comment:
Good call. Confirmed Java's check lives in
[`RESTSessionCatalog.replaceTransaction`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L1035-L1037)
and (conditionally on v1)
[`JdbcCatalog.JdbcTableBuilder.replaceTransaction`](https://github.com/apache/iceberg/blob/2f6606a247e2b16be46ca6c02fc4cfc2e17691e6/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L913-L915),
and the same idea applies on `createTable` / `renameTable`. Deferring to a
follow-up that ports the check across all the relevant call sites in one go —
dropped the helper and the call sites here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
