kevinjqliu opened a new issue, #16396: URL: https://github.com/apache/iceberg/issues/16396
context: https://lists.apache.org/thread/ddw8cvyrvypoolmzhd673s5wglhdpd5f > -- LICENSE and NOTICE are good (nit: Presto and Delta Lake has NOTICE files that could be included in the Iceberg NOTICE) > - AWS Bundle > -- nit: jar contains LICENSE/NOTICE in the root, but also META-INF/LICENSE and META-INF/NOTICE. Usually, we should have only META-INF/LICENSE and META-INF/NOTICE. Also, it seems LICENSE and NOTICE are packaged twice in the jar. -- LICENSE and NOTICE are correct (nit: aws-crt-java, aws-eventstream-java have different NOTICE then the "regular" AWS Java SDK). > - Azure Bundle > -- LICENSE and NOTICE are good (nit: NOTICE could include NOTICE content from reactor-core and reactor-netty). As for AWS bundle, filtering META-INF/LICENSE and META-INF/NOTICE in the shade plugin would be good. > - GCP Bundle > -- LICENSE and NOTICE are good (as for AWS and Azure bundle, filtering on the shade plugin would be welcome). > - Flink Runtime > -- LICENSE and NOTICE are good. Nit: LICENSE and NOTICE are packaged twice > in the jar file. META-INF/LICENSE* and META-INF/NOTICE* should be cleanup > in favor of the Iceberg LICENSE/NOTICE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
