huaxingao commented on code in PR #16108:
URL: https://github.com/apache/iceberg/pull/16108#discussion_r3261076084
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -164,6 +165,18 @@ public ThisT scanManifestsWith(ExecutorService
executorService) {
return self();
}
+ @Override
+ public ThisT commitManifestsWith(ExecutorService executorService) {
Review Comment:
nit: if a caller passes null, this throws NPE from
`executorService.getClass().getName()`.
Maybe also add
```
Preconditions.checkArgument(executorService != null, "Invalid executor
service: null");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
