smaheshwar-pltr commented on code in PR #3364:
URL: https://github.com/apache/iceberg-python/pull/3364#discussion_r3255000453
##########
pyiceberg/table/__init__.py:
##########
@@ -1685,20 +1750,19 @@ def _parse_row_filter(expr: str | BooleanExpression) ->
BooleanExpression:
return parser.parse(expr) if isinstance(expr, str) else expr
-S = TypeVar("S", bound="TableScan", covariant=True)
+A = TypeVar("A", bound="BaseScan", covariant=True)
+
+class BaseScan(ABC):
+ """A base class for all table scans."""
-class TableScan(ABC):
Review Comment:
This **isn't** a rename or removal (the diff is misleading) - `TableScan` is
just moved below the new `BaseScan` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
