kevinjqliu commented on PR #16302: URL: https://github.com/apache/iceberg/pull/16302#issuecomment-4479629155
Thanks for linking that. I think this PR is related, but it is not quite the same failure mode that Amogh was concerned about in #13033. In #13033, Spark CI was switched to a relatively narrow allow-list of known relevant paths. The concern there was that a future module could be added, forgotten in the allow-list, and then Spark CI would not run even though it should. This PR uses a different pattern: - include everything first with `**` - exclude `.github/**` - re-include the workflow’s own file - then exclude known-unrelated paths like docs/site/metadata and unrelated engine modules So new source modules are still included by default and will continue to trigger the workflow unless we explicitly exclude them. That seems to address Amogh’s suggestion to “cast a wide net on the whole project” and then exclude known irrelevant cases. The main behavior change here is scoped to `.github/**`: adding/renaming/removing unrelated workflow files no longer requires updating every CI workflow’s ignore list. The workflow’s own YAML is still re-included so edits to that workflow continue to trigger it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
