wombatu-kun commented on code in PR #16346:
URL: https://github.com/apache/iceberg/pull/16346#discussion_r3258315483
##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -50,6 +51,20 @@ public Schema schema() {
}
}
+ static class StructWithDecimals implements DataGenerator {
+ private final Schema schema =
+ new Schema(
+ required(1, "row_id", Types.StringType.get()),
Review Comment:
No — `row_id` isn't needed for the decimal write/read roundtrip and the
generator has no identity semantics. Dropped the column and renumbered the
decimal field IDs to 1/2/3 in 5dc4b5d02.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
