plusplusjiajia commented on code in PR #2332:
URL: https://github.com/apache/iceberg-rust/pull/2332#discussion_r3254469449
##########
crates/storage/opendal/src/resolving.rs:
##########
@@ -104,7 +104,20 @@ fn build_storage_for_scheme(
config: Arc::new(config),
})
}
- #[cfg(feature = "opendal-oss")]
+ // OSS is S3-API-compatible; route through S3 so `s3.*` props
+ // work for OSS-backed tables (mirrors pyiceberg/Java S3FileIO).
+ #[cfg(feature = "opendal-s3")]
+ Scheme::Oss => {
+ let config = crate::s3::s3_config_parse(props.clone())?;
+ Ok(OpenDalStorage::S3 {
+ configured_scheme: scheme.to_string(),
+ config: Arc::new(config),
+ customized_credential_load: customized_credential_load.clone(),
+ })
+ }
+ // Fallback: builds without `opendal-s3` but with `opendal-oss`
+ // still use the native OSS service (which consumes `oss.*` keys).
+ #[cfg(all(feature = "opendal-oss", not(feature = "opendal-s3")))]
Review Comment:
@CTTY Agreed, removed it. OSS is S3-compatible and the Java/Python Iceberg
implementations both route OSS through S3FileIO without a native fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
