yadavay-amzn opened a new issue, #16380: URL: https://github.com/apache/iceberg/issues/16380
Follow-up from #16237. The current unit tests for commit failure handling call `coordinator.process()` directly, which skips the production path through `CoordinatorThread.run()` and `CommitterImpl.processControlEvents()`. An end-to-end test should verify the full flow: 1. `doCommit()` throws a RuntimeException 2. `CoordinatorThread.run()` catches it, marks `terminated = true` 3. `CommitterImpl.save()` calls `processControlEvents()`, sees `coordinatorThread.isTerminated()` 4. `NotRunningException` is thrown, transitioning the Connect task to FAILED This would ensure the test still passes even if `CoordinatorThread` changes how it handles exceptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
