nssalian commented on code in PR #2423:
URL: https://github.com/apache/iceberg-rust/pull/2423#discussion_r3250412875
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -382,6 +384,7 @@ impl fmt::Display for PrimitiveType {
PrimitiveType::Uuid => write!(f, "uuid"),
PrimitiveType::Fixed(size) => write!(f, "fixed({size})"),
PrimitiveType::Binary => write!(f, "binary"),
+ PrimitiveType::Variant => write!(f, "variant"),
Review Comment:
In the Java reference implementation, VariantType implements Type directly -
it does not extend PrimitiveType. I've done the work in the iceberg-go
implementation, have a look there to understand the types:
https://github.com/apache/iceberg-go/pull/932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
