steveloughran commented on PR #16335:
URL: https://github.com/apache/iceberg/pull/16335#issuecomment-4454222348
test failures
1. regession: different exception (fix: assert differently for -Ve values)
2. others look all test suite setup, as you can no longer mimic a large
array without creating a large array, etc
```
TestSerializedArray > testEmptyArray() FAILED
java.lang.IllegalArgumentException: Variant array offset table extends
past buffer: numElements=0 offsetSize=1 remaining=2
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:484)
at
org.apache.iceberg.variants.SerializedArray.<init>(SerializedArray.java:70)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:43)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:34)
at
org.apache.iceberg.variants.TestSerializedArray.testEmptyArray(TestSerializedArray.java:58)
TestSerializedArray > testEmptyLargeArray() STARTED
TestSerializedArray > testEmptyLargeArray() FAILED
java.lang.IllegalArgumentException: Variant array offset table extends
past buffer: numElements=0 offsetSize=1 remaining=5
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:484)
at
org.apache.iceberg.variants.SerializedArray.<init>(SerializedArray.java:70)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:43)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:34)
at
org.apache.iceberg.variants.TestSerializedArray.testEmptyLargeArray(TestSerializedArray.java:67)
TestSerializedArray > testArrayOfMixedTypes() STARTED
TestSerializedArray > testArrayOfMixedTypes() PASSED
TestSerializedArray > testLargeArraySize() STARTED
TestSerializedArray > testLargeArraySize() FAILED
java.lang.IllegalArgumentException: Variant array offset table extends
past buffer: numElements=511 offsetSize=1 remaining=5
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:484)
at
org.apache.iceberg.variants.SerializedArray.<init>(SerializedArray.java:70)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:43)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:34)
at
org.apache.iceberg.variants.TestSerializedArray.testLargeArraySize(TestSerializedArray.java:183)
TestSerializedArray > testNegativeArraySize() STARTED
TestSerializedArray > testNegativeArraySize() FAILED
java.lang.AssertionError:
Expecting actual throwable to be an instance of:
java.lang.NegativeArraySizeException
but was:
java.lang.IllegalArgumentException: Invalid variant array element
count: -1
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:192)
at
org.apache.iceberg.variants.SerializedArray.<init>(SerializedArray.java:65)
at
org.apache.iceberg.variants.SerializedArray.from(SerializedArray.java:43)
...(98 remaining lines not displayed - this can be changed with
Assertions.setMaxStackTraceElementsDisplayed)
at
org.apache.iceberg.variants.TestSerializedArray.testNegativeArraySize(TestSerializedArray.java:197)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
