ldudas-marx commented on PR #16262: URL: https://github.com/apache/iceberg/pull/16262#issuecomment-4451336764
I think this PR can be split into smaller PRs: - Support predicate pushdown of non-reference terms when there is a non-reference term (this would also solve #15502) - Adding Cast as a new transform - Support Cast in Spark On the other hand I think adding a new transformation like Cast requires wider discussion. The problems I see currently: - If it cannot be used for partition values than it's not really a Transform by the description of the class - If it can be used for partitioning casting rules should be very well defined. Because all engines should be able to calculate partition values. - Cast is too general and makes the implementation complicated. The current transforms are much narrower in scope. So I would add the different casts as different transformations like ToDate, ToInt, ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
