ggershinsky commented on code in PR #16158:
URL: https://github.com/apache/iceberg/pull/16158#discussion_r3239652971
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##########
@@ -212,16 +212,22 @@ public void testInsertAndDelete() {
expected,
sql("SELECT * FROM %s ORDER BY id", tableName));
- sql("DELETE FROM %s WHERE id < 4", tableName);
+ sql("DELETE FROM %s WHERE id < 5", tableName);
- expected = ImmutableList.of(row(4L, "d", 4.0F), row(5L, "e", 5.0F),
row(6L, "f", Float.NaN));
+ expected = ImmutableList.of(row(5L, "e", 5.0F), row(6L, "f", Float.NaN));
assertEquals(
"Should return all expected rows",
expected,
sql("SELECT * FROM %s ORDER BY id", tableName));
}
+ @TestTemplate
+ public void testInsertAndDeleteMOR() {
+ sql("ALTER TABLE %s SET TBLPROPERTIES
('write.delete.mode'='merge-on-read')", tableName);
+ testInsertAndDelete();
Review Comment:
The exception is not reproduced in my environment. I ran `git clone
[email protected]:apache/iceberg.git`, changed the 8 lines in this class, and ran
`./gradlew :iceberg-spark:iceberg-spark-4.1:test --tests
org.apache.iceberg.spark.sql.TestTableEncryption`. The test passes ok. Am I
doing anything wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
