xanderbailey commented on PR #2383: URL: https://github.com/apache/iceberg-rust/pull/2383#issuecomment-4418867648
> I think we should following java's convention to store the newly created encryption keys in EncryptionManager, we will need to use them later when committing. The idea here was rather than doing the mutation as java does, we return the new keys from `wrap_key_metadata` and construct `TableUpdate::AddEncryptionKey` when we call `commit` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
