huaxingao commented on code in PR #16278:
URL: https://github.com/apache/iceberg/pull/16278#discussion_r3216287421
##########
build.gradle:
##########
@@ -581,7 +581,7 @@ project(':iceberg-aws') {
}
// TODO delete once s3-signer-open-api.yaml is removed
- def s3SignerSpec = "$projectDir/src/main/resources/s3-signer-open-api.yaml"
+ def s3SignerSpec =
layout.projectDirectory.file("src/main/resources/s3-signer-open-api.yaml")
Review Comment:
In 7.21.0,
```
// Property declared on the task:
Property<String> inputSpec // a string slot
// So .set(...) accepts a String:
inputSpec.set("$projectDir/...") // This works
```
In 7.22.0
```
// Property declared on the task:
RegularFileProperty inputSpec // a file slot
inputSpec.set("$projectDir/...") // doesn't
work
inputSpec.set(layout.projectDirectory.file("...")) // works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
