mxm commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3214266603
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -417,14 +417,8 @@ public ManifestEntry<F> apply(ManifestEntry<F> entry) {
}
};
} else {
- // data file's first_row_id is null when the manifest's first_row_id is
null
- return entry -> {
- if (entry.file() instanceof BaseFile) {
- ((BaseFile<?>) entry.file()).setFirstRowId(null);
- }
-
- return entry;
- };
+ // preserve any existing file-level first_row_id
Review Comment:
Maybe add a more explanatory comment here?
```suggestion
// We must preserve existing row id assignments. Existing entries
// carry their own file-level first_row_id from the source manifest,
// even though intermediate manifests may have a null first_row_id.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
