talatuyarer commented on code in PR #15596:
URL: https://github.com/apache/iceberg/pull/15596#discussion_r3213332825
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkFormatModels.java:
##########
@@ -53,7 +53,7 @@ public static void register() {
(icebergSchema, fileSchema, engineSchema, idToConstant) ->
SparkParquetReaders.buildReader(icebergSchema, fileSchema,
idToConstant),
new SparkVariantShreddingAnalyzer(),
- InternalRow::copy));
+ structType -> InternalRow::copy));
Review Comment:
We dont need this change anymore. Can you revert it ?
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkFormatModels.java:
##########
@@ -53,7 +53,7 @@ public static void register() {
(icebergSchema, fileSchema, engineSchema, idToConstant) ->
SparkParquetReaders.buildReader(icebergSchema, fileSchema,
idToConstant),
new SparkVariantShreddingAnalyzer(),
- InternalRow::copy));
+ structType -> InternalRow::copy));
Review Comment:
We dont need this change anymore. Can you revert it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
