RussellSpitzer commented on PR #16258: URL: https://github.com/apache/iceberg/pull/16258#issuecomment-4410358078
> i grepped for `import.*analyticscore`, looks like theres still an import in `gcp/src/main/java/org/apache/iceberg/gcp/gcs/GcsInputStreamWrapper.java` i would expect all the imports for analytics-core isolated in AnalyticsCoreUtil.java > > EDIT: ok looks like `GcsInputStreamWrapper` is only called by `AnalyticsCoreUtil`. no issues here This is actually a good call, you might as well make GcsinputStreamwrapper an inner class of AnalyticsCoreUtil and remove the possibility of another caller accidentally using it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
