steveloughran commented on PR #15629: URL: https://github.com/apache/iceberg/pull/15629#issuecomment-4408363767
switching to draft again as I'm reworking the benchmark to show variant rowgroup filtering of shredded variants works (#15510), with changes including - move to single thread spark worker (less variance in results) - going to a single large file with multiple rowgroups - exploring the difference between `variant_get(...) is 5` and `variant_get(...) in (5)` to see if spark is treating them differently. Needs an extra PR in iceberg from qlong and a snaspshot of spark 4.1 with his changes for spark to pass variant_get down So, surprisingly complex. If I can show the chain works then it's time to start with the feature merges in spark and then here. This branch will merge without direct dependency, it's just a key goal of the spark benchmark is "show pushdown working". It's not ready to merge unless it can do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
