nastra commented on PR #16207: URL: https://github.com/apache/iceberg/pull/16207#issuecomment-4405161170
> Now with this PR, the question is if we want to be robust enough on the client-side to not to have inconsistent `snapshotLog` wrt lazy snapshot loading for server implementations that interpreted the spec differently than as intended IMO the spec is pretty clear, because it mentions `snapshots` specifically and doesn't mention the `snapshotLog`. We also have a reference server implementation that only truncates the `snapshots` and if a server implementation decides to truncate the `snapshotLog` as well, then this is a bug IMO. I don't think we should be fixing the client implementation in such a case. And even if we would do that, then you'd have to apply the same fix across multiple client implementations just because a server returns incorrect table metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
