laskoviymishka opened a new pull request, #1037: URL: https://github.com/apache/iceberg-go/pull/1037
Closes #1007. V3 prefers deletion vectors over Parquet position-delete files (Iceberg spec, [apache/iceberg#12048](https://github.com/apache/iceberg/pull/12048)). Java logs a warning when the legacy format is used; iceberg-go currently writes it silently. This adds a single `slog.Warn` at the entry of the position-delete writer when the table is v3, naming the table location so users can identify which table is on the deprecated path. Once the DV writer (#997) lands and flips the default on v3, this warning becomes a backstop for users who explicitly opt back into Parquet position-deletes via `write.delete.format=position`. ## Test plan - [x] `TestPositionDeleteV3Warning/v3_warns_once_with_table_location` — captures default slog output, asserts exactly one `level=WARN` record with the canonical message and the table location. - [x] `TestPositionDeleteV3Warning/v2_does_not_warn` — captures slog output on a v2 write and asserts no warnings fire (legacy format is canonical on v2). - [x] Existing `TestPositionDelete*` tests still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
