Fokko commented on code in PR #3207:
URL: https://github.com/apache/iceberg-python/pull/3207#discussion_r3201382943
##########
tests/expressions/test_parser.py:
##########
@@ -272,3 +279,86 @@ def test_valid_between_with_numerics() -> None:
) == parser.parse("foo between '2025-01-01T00:00:00.000000' and
'2025-01-10T12:00:00.000000'")
assert parser.parse("foo between 1 and 3") == parser.parse("1 <= foo and
foo <= 3")
+
+
+def test_cast_date_comparison() -> None:
+ expected = EqualTo(
+ UnboundTransform(Reference("created_at"), DayTransform()),
+ StringLiteral("2024-01-01"),
+ )
Review Comment:
For testing, I think it would be good to have an integration test as well.
The `StringLiteral` should be converted to a `DateLiteral` when bound to the
transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
