nastra commented on code in PR #14234: URL: https://github.com/apache/iceberg/pull/14234#discussion_r3199488068
########## format/spec.md: ########## @@ -683,6 +683,13 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access to a deletion vector. For deletion vectors, these values are required and must exactly match the `offset` and `length` stored in the Puffin footer for the deletion vector blob. 6. The following field ids are reserved on `data_file`: 141. +###### File-level column statistics Review Comment: I'm ok adding it as part of this PR but I feel that this would cause a lot of unnecessary changes because the overview table needs to change and we need to add v4 and the new field there. https://github.com/apache/iceberg/pull/16025/changes#diff-36347a47c3bf67ea2ef6309ea96201814032d21bb5f162dfae4045508c15588aR677 already includes the content_stats field under field ID 146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
