rdblue commented on code in PR #16196: URL: https://github.com/apache/iceberg/pull/16196#discussion_r3191457310
########## aws-bundle/NOTICE: ########## @@ -332,3 +332,20 @@ This product bundles Netty with the following in its NOTICE file: | * license/LICENSE.brotli4j.txt (Apache License 2.0) | * HOMEPAGE: | * https://github.com/hyperxpro/Brotli4j + +-------------------------------------------------------------------------------- + +This product bundles AWS Analytics Accelerator S3 with the following in its NOTICE file: Review Comment: I think it's debatable whether we need this. The copyright information is documented in the LICENSE file and this appears to be simply boilerplate. I'm fine adding it, but it doesn't seem strictly necessary to comply with license terms. If we include it, we should just have the one line, without extra quoted lines around it and without the unnecessary whitespace. Just one empty line between paragraphs, quoted content, and separator lines should do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
