zeroshade commented on code in PR #985:
URL: https://github.com/apache/iceberg-go/pull/985#discussion_r3189474435
##########
manifest.go:
##########
@@ -463,6 +481,13 @@ type ManifestFile interface {
HasAddedFiles() bool
// HasExistingFiles returns true if ExistingDataFiles > 0 or if it was
null.
HasExistingFiles() bool
+ // Entries streams the manifest entries from the manifest file using
+ // the provided file system IO interface. Entries that have been
+ // marked as deleted are skipped if discardDeleted is true.
+ //
+ // Prefer Entries over FetchEntries when walking large manifests
+ // since it avoids loading every entry into memory at once.
+ Entries(fs iceio.IO, discardDeleted bool) iter.Seq2[ManifestEntry,
error]
Review Comment:
I think it's fine to deprecate and add the new method since we're 0.x as
long as we make sure to call it out in the next release (i.e. change the title
of this to be `fix(manifest)!:` so that i gets called out as a breaking change).
Eventually we're going to want to overhaul the public API before we do a 1.0
release anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
