ebyhr commented on code in PR #16191:
URL: https://github.com/apache/iceberg/pull/16191#discussion_r3185221623


##########
flink/v2.1/build.gradle:
##########
@@ -33,7 +33,7 @@ project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}") {
     implementation project(':iceberg-hive-metastore')
 
     compileOnly libs.flink21.avro
-    compileOnly 'joda-time:joda-time:2.8.1'
+    compileOnly libs.joda.time

Review Comment:
   `libs.joda.time` requirers a new entry in `[libraries]` libs.versions.toml: 
   ```yml
   joda-time = { module = "joda-time:joda-time", version.ref = "joda" }
   ```
   
   If your intention is only to define the version in libs.versions.toml, you 
can change this line like:
   ```gradle
   compileOnly "joda-time:joda-time:${libs.versions.joda.get()}"
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to