tanmayrauth commented on PR #968: URL: https://github.com/apache/iceberg-go/pull/968#issuecomment-4375411855
Addressed all points: (1) Fixed the warehouse path mismatch - now using /tmp/iceberg-hadoop- warehouse:/tmp/iceberg-hadoop-warehouse (same absolute path on both sides, matching the Hive pattern). (2) Added make integration-hadoop-clean for resetting state between local runs. (3) Replaced sleep 10 with docker compose up --wait + a healthcheck on spark-iceberg, so local and CI behave identically. (4) Added make integration-down, integration-logs, and integration-env helper targets. (5) hadoop_validation.py now supports --assert-rows to verify actual query results, not just "Spark didn't crash." Agreed on testcontainers-go as a good future direction these changes should make that migration straightforward since the path contract is now unambiguous. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
