dramaticlly commented on code in PR #16184:
URL: https://github.com/apache/iceberg/pull/16184#discussion_r3183609665


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -37,6 +39,10 @@
 /** A {@link Table} implementation that exposes a table's partitions as rows. 
*/
 public class PartitionsTable extends BaseMetadataTable {
 
+  // partition dependent field id

Review Comment:
   Sounds good, moved all schema to the class members but only kept the field 
id for partitions as it depends on the table schema. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to