kevinjqliu commented on code in PR #3299:
URL: https://github.com/apache/iceberg-python/pull/3299#discussion_r3174339128
##########
.github/workflows/svn-build-artifacts.yml:
##########
@@ -69,7 +70,7 @@ jobs:
env:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
- CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
+ CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<=3.14"
Review Comment:
```suggestion
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.15"
```
this is a subtle bug, `<=3.14` will not match patch releases, 3.14.1, ...
so we have to use <
##########
Makefile:
##########
@@ -115,7 +115,7 @@ test-integration-setup: install ## Start Docker services
for integration tests
uv run $(PYTHON_ARG) python dev/provision.py
test-integration-exec: ## Run integration tests (excluding provision)
- $(TEST_RUNNER) pytest tests/ -m integration $(PYTEST_ARGS)
+ RAY_ENABLE_UV_RUN_RUNTIME_ENV=0 $(TEST_RUNNER) pytest tests/ -m
integration $(PYTEST_ARGS)
Review Comment:
i dont like that we're dependent on this env var to be set correctly for
tests to pass. Lets see if there's an alternative. I'll do some research
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
