pvary commented on code in PR #16183:
URL: https://github.com/apache/iceberg/pull/16183#discussion_r3172625594


##########
gradle/libs.versions.toml:
##########
@@ -67,6 +67,7 @@ jakarta-servlet-api = "6.1.0"
 jaxb-api = "2.3.1"
 jaxb-runtime = "2.3.9"
 jetty = "12.1.8"
+joda-time = "2.5"

Review Comment:
   This is compile only dependency and dynamically loaded, based on the lib 
availability, so this is fine.
   
   OTOH this change is mixing a backport with the fix for handling the library 
versions correctly.
   
   @talatuyarer: Please separate it to a different PR and hold off the merge 
until it is merged.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to