huaxingao commented on code in PR #16186:
URL: https://github.com/apache/iceberg/pull/16186#discussion_r3172331133
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -135,9 +134,7 @@ public AzureProperties(Map<String, String> properties) {
}
this.keyWrapAlgorithm =
- properties.getOrDefault(
- AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM,
- KeyWrapAlgorithm.RSA_OAEP_256.getValue());
+
properties.getOrDefault(AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM,
"RSA-OAEP-256");
Review Comment:
Could we extract this into a named constant with a comment noting which
Azure SDK value it mirrors? Something like:
```
> // Must match KeyWrapAlgorithm.RSA_OAEP_256.getValue() from
azure-security-keyvault-keys
> private static final String DEFAULT_KEY_WRAP_ALGORITHM = "RSA-OAEP-256";
>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
